Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assyst stability #159

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Assyst stability #159

merged 10 commits into from
Oct 17, 2024

Conversation

pmrv
Copy link
Collaborator

@pmrv pmrv commented Oct 17, 2024

Clears up min_dist handling some more and fixes smaller problems.

and do not filter if no min_dist given
In the VolMin step it would never be fullfilled as atoms cannot move.
IBRION=2 seems to be more stable than 1 for our "strange" structures.
Lower POTIM also helps that minimizer steps do not jump to strange places
on high forces/stresses.
Before DFT calculations we do it anyway and allowing them during VolMin gives AllMin
a chance to fix some of them.
Insufficients NBANDS is the biggest fix we apply.  Can be improved by allowing
empty states per atom, but needs support from atomistics.
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_potentialfit/assyst

@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11387940861

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 83 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 3.896%

Files with Coverage Reduction New Missed Lines %
atomistics/job/trainingcontainer.py 83 49.55%
Totals Coverage Status
Change from base Build 11375329038: 0.05%
Covered Lines: 193
Relevant Lines: 4954

💛 - Coveralls

@pmrv pmrv merged commit 3fc4ced into main Oct 17, 2024
12 of 14 checks passed
@pmrv pmrv deleted the assyst branch October 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants