Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade pyparsing #800

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Downgrade pyparsing #800

merged 9 commits into from
Aug 2, 2023

Conversation

srmnitc
Copy link
Member

@srmnitc srmnitc commented Aug 2, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/downgrade_pyparsing

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Pull Request Test Coverage Report for Build 5741119168

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 14.155%

Totals Coverage Status
Change from base Build 5714834727: 1.0%
Covered Lines: 2087
Relevant Lines: 14744

💛 - Coveralls

@jan-janssen
Copy link
Member

Should not we just update matplotlib to again be compatible to pyiron_atomistics? From my perspective we can now disable python 3.8 on pyiron_contrib and then we should be able to update the open dependency bot pull requests.

@srmnitc
Copy link
Member Author

srmnitc commented Aug 2, 2023

https://github.com/conda-forge/matplotlib-feedstock/blob/main/recipe/meta.yaml seems to still have pyparsing constraint.

.binder/environment.yml Outdated Show resolved Hide resolved
docs/environment.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@jan-janssen
Copy link
Member

https://github.com/conda-forge/matplotlib-feedstock/blob/main/recipe/meta.yaml seems to still have pyparsing constraint.

The issue is that these constraints were only introduced in matplotlib =3.7.2 so by removing Python 3.8 support and updating matplotlib to 3.7.2 we should be able to spot the issue here in this repository before we make a new release.

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit 9101f29 into main Aug 2, 2023
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the downgrade_pyparsing branch August 2, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants