Clean executor fails #777
Merged
Clean executor fails #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, on_run should be a property returning a callable
They are not implemented and working yet, so at least fail cleanly!
|
|
|
@samwaseda you're welcome to review this, but IMO it's low priority as I'm just making sure we have cleaner errors in an edge case. There's a chance that Jan's |
And downstream stuff like `update` and thus `__call__`. This was requested by Joerg and now makes things really start to feel like regular python
We may wish to later make Macro's slow, but for Workflows, since the IO is just routing through to the owned nodes, input updates are _anyhow_ most of the time re-running things, so it's a sensible default IMO
Return output when calling `run`
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on an executor is giving me
TypeError: cannot pickle '_thread.lock' object, i.e. forFunctionnodes that useselfand forCompositenodes we can't yet use an executor. Until this is fixed, it should fail cleanly and informatively.