You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have NotData in place (#754), we can safely make the standard behaviour for Function nodes to be "fast" (running when input is updated). SingleValue is reparented right onto Function, and Fast is replaced by Slow (which is just a Function with different defaults for the run flags). This makes the standard Function behaviour more intuitive and streamlines some of the pedagogical stuff.
@samwaseda, your reviews and PRs have made the workflow module strictly and substantially better, but there are many weeks where this is the main thing I've got to work on while I imagine you have a number of things on your plate -- so I want to be super conscious of not monopolizing your time, and I don't always want to wait for you to get to the reviews before continuing my work! I think stacking PRs is a good first-order solution to these problems, but I'm very open to having a discussion about our process in case you are tired of all the pings or have ideas for how we can make things even more efficient 😄
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have
NotDatain place (#754), we can safely make the standard behaviour forFunctionnodes to be "fast" (running when input is updated).SingleValueis reparented right ontoFunction, andFastis replaced bySlow(which is just aFunctionwith different defaults for the run flags). This makes the standardFunctionbehaviour more intuitive and streamlines some of the pedagogical stuff.