Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Build IO in the property if it doesn't exist already #737

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

liamhuber
Copy link
Member

This brings it into better alignment with Workflow, where Input and Output are properties (returning the correct type over in #729).

I expect this to make it easier to make an abstract parent for both Workflow and Node, because now such a parent can just expect self.inputs and self.outputs to give back a class of the right type at all times.

@liamhuber liamhuber requested a review from samwaseda June 22, 2023 22:25
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/delay_io_creation

@liamhuber liamhuber changed the title Build IO in the property if it doesn't exist already Workflow: Build IO in the property if it doesn't exist already Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the branch main June 23, 2023 14:32
@liamhuber liamhuber changed the base branch from roll_back_storage_priority to main June 23, 2023 16:34
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 5382199053

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 11.946%

Totals Coverage Status
Change from base Build 5382174367: 0.06%
Covered Lines: 1680
Relevant Lines: 14063

💛 - Coveralls

@samwaseda samwaseda merged commit 88ef864 into main Jun 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the delay_io_creation branch June 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants