Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Remove storage priority #736

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

liamhuber
Copy link
Member

It didn't actually do anything yet, so let's hold off implementing it until we have serialization for it to work with.

It didn't actually do anything yet, so let's hold off implementing it until we have serialization for it to work with.
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/roll_back_storage_priority

@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 5350794802

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 11.822%

Totals Coverage Status
Change from base Build 5350348004: -0.07%
Covered Lines: 1660
Relevant Lines: 14042

💛 - Coveralls

@liamhuber liamhuber requested a review from samwaseda June 22, 2023 22:25
@liamhuber
Copy link
Member Author

I don't hate the idea of having storage priorities in roughly this way, I just feel that I did some premature optimization and want to unwind it.

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree that it's better to not offer something that doesn't exist XD but it's gonna hopefully come back very soon in the future.

@samwaseda samwaseda merged commit 9378cc9 into main Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the roll_back_storage_priority branch June 23, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants