Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calc static #715

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Add calc static #715

merged 6 commits into from
Jun 19, 2023

Conversation

liamhuber
Copy link
Member

New node. Maybe many output components should be parsed to not be wrapped in a list, since calc static always returns a single frame?

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/add_calc_static

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

Pull Request Test Coverage Report for Build 5315033904

  • 7 of 14 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 12.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_contrib/workflow/node_library/atomistics.py 5 12 41.67%
Files with Coverage Reduction New Missed Lines %
pyiron_contrib/workflow/node_library/atomistics.py 1 45.1%
Totals Coverage Status
Change from base Build 5249449584: 0.02%
Covered Lines: 1663
Relevant Lines: 12800

💛 - Coveralls

@liamhuber
Copy link
Member Author

This has #716 stacked on top of it, so I'm not hellbent on getting a test/example into this one until we see how that pans out.

@liamhuber liamhuber requested a review from samwaseda June 13, 2023 18:38
@samwaseda
Copy link
Member

Maybe many output components should be parsed to not be wrapped in a list, since calc static always returns a single frame?

Yes, without looking at this comment of yours (i.e. after seeing your changes), I thought the same. Let me see if I can find something.

@liamhuber liamhuber added the format_black Invoke a black formatting commit label Jun 19, 2023
@liamhuber
Copy link
Member Author

@samwaseda, I like that this spawned #717, but since it's just "content" I'll merge it. Then we can apply the ideas of #717 in a later PR.

@samwaseda
Copy link
Member

@samwaseda, I like that this spawned #717, but since it's just "content" I'll merge it. Then we can apply the ideas of #717 in a later PR.

Fine by me

@liamhuber liamhuber merged commit f4622bc into main Jun 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the add_calc_static branch June 19, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black Invoke a black formatting commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants