Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node status #666

Merged
merged 9 commits into from
May 8, 2023
Merged

Node status #666

merged 9 commits into from
May 8, 2023

Conversation

liamhuber
Copy link
Member

Adds new running and failed flags to Node.

running is turned on then off inside the run method; failed gets set when the node function raises an error. Nodes that are running or failed are not ready. Nodes that are running cannot be run, nor will their input data channels update.

For now, none of this is useful, but node status will be necessary once we introduce executors and the workflow is able to do other things while a node runs (either in the background or remotely).

@coveralls
Copy link

coveralls commented May 8, 2023

Pull Request Test Coverage Report for Build 4919472903

  • 19 of 20 (95.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 13.676%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_contrib/workflow/node.py 13 14 92.86%
Totals Coverage Status
Change from base Build 4915188369: 0.1%
Covered Lines: 1692
Relevant Lines: 12372

💛 - Coveralls

@liamhuber liamhuber merged commit 0311eb7 into main May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the node_status branch May 8, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants