Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lammps notebook #1121

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Update lammps notebook #1121

merged 1 commit into from
Aug 2, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Aug 2, 2024

The example resource wants to use lmp, but lammps conda package provides lmp_mpi only. Maybe that changed recently?

Also updated the notebook to not hard code my own filesystem paths anymore. Oops.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/note

The example resource wants to use lmp, but lammps conda package provides lmp_mpi only.
Maybe that changed recently?

Also updated the notebook to not hard code my own filesystem paths
anymore. Oops.
Copy link

codacy-production bot commented Aug 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (55e6a34) 10126 1280 12.64%
Head commit (8fe9576) 10126 (+0) 1280 (+0) 12.64% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1121) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Aug 2, 2024

Pull Request Test Coverage Report for Build 10216641843

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.641%

Totals Coverage Status
Change from base Build 10216434347: 0.0%
Covered Lines: 1280
Relevant Lines: 10126

💛 - Coveralls

@pmrv pmrv merged commit 186a8cc into main Aug 2, 2024
18 checks passed
@pmrv pmrv deleted the note branch August 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants