Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base/atomistics/pymatgen together #1119

Merged
merged 29 commits into from
Aug 2, 2024
Merged

Bump base/atomistics/pymatgen together #1119

merged 29 commits into from
Aug 2, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Aug 2, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/bumps

@jan-janssen jan-janssen closed this Aug 2, 2024
@jan-janssen jan-janssen reopened this Aug 2, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 013da4f1 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (013da4f) Report Missing Report Missing Report Missing
Head commit (60c6948) 10126 1280 12.64%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1119) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@pmrv pmrv merged commit 55e6a34 into main Aug 2, 2024
17 checks passed
@pmrv pmrv deleted the bumps branch August 2, 2024 13:28
@pmrv pmrv mentioned this pull request Aug 2, 2024
@samwaseda
Copy link
Member

I don't really understand how this solved the problem? Is there a clear explanation?

@pmrv
Copy link
Contributor Author

pmrv commented Aug 2, 2024

For the pycp2k problem, we just dropped the package from the env, because we figured it's an issue with their pip package maybe not supporting python3.12 yet.
The notebook failure was caused by there not being a lmp executable even when lammps was installed, @jan-janssen said this may have been an old lammps package that was pulled by our env, since we don't pin the version there.
The other changes are just updating the action to the latest versions, I'm not sure if that did something indirectly.

@samwaseda
Copy link
Member

God I wasted 2 days trying to figure out the problem. This shouldn't happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants