-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default project for WorkerJob #645
Conversation
Mh, I've noticed now that this creates the problem that the worker is waiting for itself to finish, which is also a bit borked... |
That is strange - I initially had an implementation where the worker was watching a specific project, but by now it should only filter based on the |
Ah, I think I just got confused by the worker log. I had tried to create & submit my worker job, submit all the smaller calculations and then immediately set the worker status to collect, hoping that this would shut down the worker once all the jobs are finished. Alas, when the worker started running on the node it changed its status away from The new default works for me, if you don't have objections I'll merge this later today. |
I guess what you are looking for is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Jan Janssen <[email protected]>
Co-authored-by: Jan Janssen <[email protected]>
The issue was that I didn't want to block the notebook, but continue working on other things, but I haven't come up with anything better yet. |
The
WorkerJob
needs an input project assigned, but the default isNone
and it's not checked before the worker job starts running, which leads to silent death of the worker if you forget to assign one. I've set the default now to be the project of the worker itself, because that seems to me the common use case. If that's too specific we should instead add avalidate_ready_to_run
method that does this check.