Always write error.out #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously error.out was written when the job was successful and error.msg when not. In case the job returned an accepted non zero return nothing was written due to a bug. This commit writes all the output of the job to error.out in all cases, plus error.msg when the job errors out for backwards compatibility.
pmrv
added
bug
|
@niklassiemer It seems the macos tests are broken right now, did that happen for other PRs as well? |
|
Seems to be related to #646. Skimming through recent PRs, this problem pops up in a few places. |
|
I now merged the PR from Jan and retriggered the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously error.out was written when the job was successful and
error.msg when not. In case the job returned an accepted non zero
return nothing was written due to a bug. This commit writes all the
output of the job to error.out in all cases, plus error.msg when the job
errors out for backwards compatibility.
I introduced the bug in #537.