Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default arguments to JobCore.get #562

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Allow default arguments to JobCore.get #562

merged 1 commit into from
Nov 26, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Nov 25, 2021

No description provided.

@pmrv pmrv added the enhancement New feature or request label Nov 25, 2021
niklassiemer
niklassiemer approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@niklassiemer niklassiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pmrv pmrv added the integration Start the integration tests with pyiron_atomistics/contrib for this PR label Nov 26, 2021
@pmrv pmrv merged commit d1fa086 into master Nov 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the get-default branch November 26, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklassiemer niklassiemer niklassiemer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request integration Start the integration tests with pyiron_atomistics/contrib for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmrv @niklassiemer