Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in case of None type values #488

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Bugfix in case of None type values #488

merged 2 commits into from
Nov 9, 2021

Conversation

sudarsan-surendralal
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal commented Oct 24, 2021 •
edited
Loading

This is a hotfix. So I'll refine this later

Edit: Turns out the Hotfix could be sufficient. This is necessary to handle NoneType values

@sudarsan-surendralal sudarsan-surendralal added the bug Something isn't working label Oct 24, 2021
@stale
Copy link

stale bot commented Nov 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 8, 2021
@sudarsan-surendralal sudarsan-surendralal marked this pull request as ready for review November 9, 2021 14:15
@stale stale bot removed the stale label Nov 9, 2021
@jan-janssen
Copy link
Member

When you say nonetype values, are these entries in the job? I do not really like the try and except part.

@sudarsan-surendralal
Copy link
Member Author

When you say nonetype values, are these entries in the job? I do not really like the try and except part.

Yes they are in the job. The np.concatenate function does not work on such values.

jan-janssen
jan-janssen approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sudarsan-surendralal sudarsan-surendralal merged commit 1846711 into master Nov 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the serial_bugfix branch November 9, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@pmrv pmrv Awaiting requested review from pmrv

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudarsan-surendralal @jan-janssen