Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flattened storage store defaults #429

Merged
merged 17 commits into from
Sep 10, 2021
Merged

Flattened storage store defaults #429

merged 17 commits into from
Sep 10, 2021

Conversation

Leimeroth
Copy link
Member

This makes sure that the fill value set when using add_arrays is also set when resizing arrays.

@Leimeroth Leimeroth requested a review from pmrv September 9, 2021 09:56
pmrv
pmrv approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pmrv
Copy link
Contributor

pmrv commented Sep 9, 2021

Ah, please add a few unit tests pyiron_base/generic/test_flattenedstorage.py. Should test at least

  1. arrays without a fill are unchanged after resize (value-wise)
  2. arrays with a fill have the correct value in the new portion of the array (and only there)
  3. _default_values is correctly read from HDF.

Ah and also rename _default_values to fill_values. The rest of the code refers to them as fill, so it should be consistent.

@Leimeroth Leimeroth merged commit 4038228 into master Sep 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the FlattenedStorage-StoreDefaults branch September 10, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leimeroth @pmrv