Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tqdm to Project.iter_jobs #423

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Add tqdm to Project.iter_jobs #423

merged 1 commit into from
Sep 15, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Aug 30, 2021

Sometimes iteration over jobs in a project can be a bit slow-ish, so I often want to have some progress update, but I always forget about tqdm, so I thought I'd add it by default.

Since is strictly QoL so I'm open to discussion to leave the default to False or not merge this PR at all, depending on y'alls opinion. ;)

@pmrv pmrv added the enhancement New feature or request label Aug 30, 2021
@stale
Copy link

stale bot commented Sep 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 13, 2021
@pmrv pmrv removed the stale label Sep 13, 2021
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit c125b68 into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the tqdm-job branch September 15, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants