Extend load_file to handle file objects.
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrv
reviewed
Jul 23, 2021
Co-authored-by: Marvin Poul <[email protected]>
niklassiemer
added
the
integration
pmrv
reviewed
Jul 27, 2021
pyiron_base/generic/filedata.py
Outdated
Comment on lines
88
to
92
| if is_file: | ||
| with open(file, encoding='utf8') as f: | ||
| return f.readlines() | ||
| else: | ||
| return file.readlines() |
There was a problem hiding this comment.
I'm not sure the extra flag is needed, maybe something like
Suggested change
| if is_file: | |
| with open(file, encoding='utf8') as f: | |
| return f.readlines() | |
| else: | |
| return file.readlines() | |
| if instance(file, io.IOBase): | |
| return file.readlines() | |
| else: | |
| with open(file, encoding='utf8') as f: | |
| return _load_txt(f) |
is better.
There was a problem hiding this comment.
Probably we should then go the whole way and use this check instead of generating the filename_is_string at all.
pmrv
reviewed
Jul 27, 2021
| return _load_default(fp, is_file=filename_is_str) | ||
|
|
||
|
|
||
| class FileDataTemplate(ABC): |
There was a problem hiding this comment.
I didn't see it before, but where else is the FileDataTemplate supposed to be used?
There was a problem hiding this comment.
I hope to have it as a Base class for storing File related data. I am using this also for the S3FileData here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.