Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASE: Set calculator to structure before initializing the Executor #189

Closed
wants to merge 1 commit into from

Conversation

jan-janssen
Copy link
Member

This caused the calculator in the Molecular Dynamics calcualtion to be overwritten.

This caused the calculator in the Molecular Dynamics calcualtion to be overwritten.
@jan-janssen jan-janssen requested a review from liamhuber January 9, 2024 20:48
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused the calculator in the Molecular Dynamics calcualtion to be overwritten.

I'm not sure I'm familiar enough with ASE and how its structure and calculator objects interact, so take this with a big grain of salt, but this smells dangerous to me.

I would expect there to be some guarantee that the calculator at evaluation time is the same calculator I defined at the beginning of the run... Is this a faulty assumption? The direction I'm thinking is to still take the calculator in the output object, but instead of applying it ot the structure's .calc attribute just self.structure.calculator is not ase_calculator: raise ValueError(...) or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants