Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: generate: Hint callbacks #145

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

matperc
Copy link
Collaborator

@matperc matperc commented May 29, 2023

Blocked by this bug python/mypy#15177

Closes #144
Closes #149

@matperc matperc marked this pull request as draft May 29, 2023 14:07
@matperc matperc marked this pull request as ready for review September 22, 2023 11:34
@matperc
Copy link
Collaborator Author

matperc commented Sep 22, 2023

The bug in mypy is fixed so it should work now.

@lovetox can you test on your code base if everything works fine?

@matperc
Copy link
Collaborator Author

matperc commented Sep 22, 2023

There is a problem on typing with Gio.AsyncReadyCallback it should take var args

I've fixed this. It works now, I'll leave the draft status since it works only with mypy master.

@matperc matperc marked this pull request as draft September 22, 2023 12:37
@matperc matperc marked this pull request as ready for review November 23, 2023 08:23
@matperc
Copy link
Collaborator Author

matperc commented Nov 23, 2023

With mypy 1.7 it's working. Before merge please check if it is working as expected in your codebase

@lovetox
Copy link
Collaborator

lovetox commented Feb 11, 2024

This generates for me invalid python, if i try it on Gtk3

xoptions=<flags GTK_EXPAND | GTK_FILL of type Gtk.AttachOptions>

also please make a second space between code and FIXME comment

: ... # FIXME Function -> : ... # FIXME Function

This reduces the work the formatter has to do

@lovetox
Copy link
Collaborator

lovetox commented Feb 11, 2024

oh it seems its not this MR that does this, i have this also on master

I added #169

@lovetox
Copy link
Collaborator

lovetox commented Feb 11, 2024

i tested this and didnt run into any problems with the MR.

@matperc
Copy link
Collaborator Author

matperc commented Feb 17, 2024

also please make a second space between code and FIXME comment

: ... # FIXME Function -> : ... # FIXME Function

This reduces the work the formatter has to do

Is this related to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of user_data is None throughout the stubs Possible way to type hint callbacks
2 participants