Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with pygfx/rendercanvas#36. Probably won't entirely close it yet.
Changes
canvas.get_window_id()
intocanvas.get_surface_info()
to package all info in one dict, so that theget_display_id()
method can be removed, and we can add info on the platform that the GUI toolkit uses (x11/wayland).gui._gui_utils
module to put some of this logic in.gui.base
to the gui utils module.Notes: