Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland support by forcing x11 #470

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Wayland support by forcing x11 #470

merged 10 commits into from
Mar 6, 2024

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Mar 1, 2024

Deals with pygfx/rendercanvas#36. Probably won't entirely close it yet.

Changes

  • Change canvas.get_window_id() into canvas.get_surface_info() to package all info in one dict, so that the get_display_id() method can be removed, and we can add info on the platform that the GUI toolkit uses (x11/wayland).
  • New gui._gui_utils module to put some of this logic in.
  • Also moved some utlils from gui.base to the gui utils module.
  • Make it work for GLFW, by forcing x11.
  • Make it work for Qt, by forcing x11.
  • Make it work for wx, by forcing x11 (untested).
  • Make sure the docs are correct.
  • Add notes to the top post of WindowManager: Linux Wayland support rendercanvas#36.

Notes:

  • This PR could be smaller if it'd just force x11 for glfw and qt, but in the process of trying out things, I also refactored a bit. These extra changes do make the code more "future ready" for when Wayland is supported better.
  • Not sure what happens on more special linuxes like Raspberry Pi.

@almarklein almarklein changed the title Wayland support Wayland support by forcing x11 Mar 1, 2024
@almarklein almarklein marked this pull request as ready for review March 1, 2024 15:42
@almarklein almarklein requested a review from Korijn as a code owner March 1, 2024 15:42
@almarklein almarklein marked this pull request as draft March 1, 2024 15:42
@almarklein
Copy link
Member Author

almarklein commented Mar 1, 2024

I pushed new commits to this branch but they don't show up here.

edit: they are visible now

@almarklein almarklein marked this pull request as ready for review March 1, 2024 15:46
@Korijn Korijn enabled auto-merge (squash) March 6, 2024 10:00
@Korijn Korijn merged commit eced145 into main Mar 6, 2024
20 checks passed
@Korijn Korijn deleted the wayland branch March 6, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants