Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 3140 draw.aaline width #3192

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

ankith26
Copy link
Member

Reverts #3140 completely. #3182 is doing a partial revert already but I believe a full revert is safer in this case, especially given the author of the original PR has come up with an entirely new implementation

@ankith26 ankith26 added this to the 2.5.2 milestone Oct 23, 2024
@ankith26 ankith26 requested a review from a team as a code owner October 23, 2024 11:59
@ankith26 ankith26 force-pushed the revert-3140-draw.aaline_width branch from ae3d9b5 to 019f561 Compare October 23, 2024 12:01
@ankith26 ankith26 force-pushed the revert-3140-draw.aaline_width branch from 019f561 to 5ddc43c Compare October 23, 2024 12:02
@yunline yunline added draw pygame.draw bugfix PR that fixes bug labels Oct 24, 2024
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oddbookworm
Copy link
Member

I'm curious why only the circleci runs ran here

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although, I'm not merging quite yet until I understand why not all actions ran here

@ankith26
Copy link
Member Author

github CI is only configured to run on pushes and PRs made against the main branch. The CI is going to do a run during the release as well, so if there is any issue we can still catch it then

@oddbookworm
Copy link
Member

🤦‍♂️ yep, I should have paid attention to what branch it was going to

@oddbookworm oddbookworm merged commit 19fea51 into 2.5.2 Oct 26, 2024
1 check passed
@ankith26 ankith26 deleted the revert-3140-draw.aaline_width branch November 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR that fixes bug draw pygame.draw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants