-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Line
methods and length
attribute
#3179
Added Line
methods and length
attribute
#3179
Conversation
## Credits **Geometry Project:** For code, docs and tests: @novialriptide @Emc2356 @itzpr3d4t0r @ScriptLineStudios @avaxar @Matiiss @newpaxonian @maqa41 @blankRiot96 Also thanks to @Starbuck5 for kickstarting the idea and the occasional help! **Functionality added in this PR** - `line.c` https://github.com/pygame-community/pygame-geometry/blame/main/src_c/line.c Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar - `geometry.pyi` https://github.com/pygame-community/pygame-geometry/blame/main/geometry.pyi Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar - `geometry_test.py` https://github.com/pygame-community/pygame-geometry/blame/main/test/test_line.py Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar - `geometry.rst` https://github.com/pygame-community/pygame-geometry/blame/main/docs/line.rst Credits to @itzpr3d4t0r @avaxar @ScriptLineStudios - `geometry.h` https://github.com/pygame-community/pygame-geometry/blame/main/src_c/include/geometry.h Credits to @Emc2356 @itzpr3d4t0r @maqa41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope none of what I said is wrong. Thanks for contributing btw :)
noted, will fix throughout the day. |
I would like you or the person merging this PR (via squash) to correctly add co-author information to the ported commits. |
what do you mean? |
Check out how the other geometry PRs are handled. For instance in #3071 you can see the first commit correctly credits the multiple authors. This is done by adding something like
to the description/body of the git commit |
i see. But how would i go about collecting their email addresses? as well as edit the commit? |
The block of code with the emails has already been posted by me in my previous message. Okay never mind, let the merger handle it for now, this is just something for you to keep in mind for future PRs |
should i just wait for the next pr to fix the geometry.line doc typos or should i fix it before merging? |
Are the typos related to this PR? If so, then fix them here. If they're unrelated and you just want to fix them, make that a separate PR. It's easier to get things through if you don't push too many unrelated things together |
the next pr i will make is also regarding line, which will also change the docs for that, but yes the typos are in this pr |
Fix what this PR touches, and then fix what the next PR touches if needed in that PR. If there are others you want to fix, fix them in a separate fix PR |
Co-authored-by: Emc2356 <[email protected]> Co-authored-by: NovialRiptide <[email protected]> Co-authored-by: ScriptLineStudios <[email protected]> Co-authored-by: Avaxar <[email protected]> Co-authored-by: maqa41 <[email protected]>
Line
methods and length
attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok LGTM! Thanks for contributing!!
Btw this PR is still not crediting me, so whoever merges this should squash the commits and add this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks good to me 👍
Docs, tests & stubs in place. I'm not super certain why you'd want to flip a line yet... but I'm sure there is a use.
Added
Attributes
Methods
Credits
Geometry Project:
For code, docs and tests:
@novialriptide @Emc2356 @itzpr3d4t0r @ScriptLineStudios @avaxar @Matiiss @newpaxonian @maqa41 @blankRiot96 Also thanks to @Starbuck5 for kickstarting the idea and the occasional help!
Functionality added in this PR
line.c
https://github.com/pygame-community/pygame-geometry/blame/main/src_c/line.c Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxargeometry.pyi
https://github.com/pygame-community/pygame-geometry/blame/main/geometry.pyi Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxargeometry_test.py
https://github.com/pygame-community/pygame-geometry/blame/main/test/test_line.py Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxargeometry.rst
https://github.com/pygame-community/pygame-geometry/blame/main/docs/line.rst Credits to @itzpr3d4t0r @avaxar @ScriptLineStudiosgeometry.h
https://github.com/pygame-community/pygame-geometry/blame/main/src_c/include/geometry.h Credits to @Emc2356 @itzpr3d4t0r @maqa41