Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize window docs #3170

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

Starbuck5
Copy link
Member

This PR represents the transition of the Window API to the pygame-ce public API.

I left it in the "other" category in the top bar in the docs, as it's not quite experimental not quite advanced, hopefully it's useful! It can be recategorized later of course.

I also expect lots of API additions later, as we see how people use this and what stuff we've missed.

I would also like to get some more in depth examples on how to use this in before 2.5.2-final, but that doesn't block a dev release necessarily.

I know there's still debate about features of this, and I don't want to clobber that, but I feel that getting this functionality available to our users will be valuable. We don't want to let the perfect be the enemy of the good, and this module has been in the oven for a long time. There's still lots of room for iteration after it becomes a public API.

@Starbuck5 Starbuck5 added docs window pygame.Window labels Oct 12, 2024
@Starbuck5 Starbuck5 added this to the 2.5.2 milestone Oct 12, 2024
@Starbuck5 Starbuck5 requested a review from a team as a code owner October 12, 2024 10:18
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fine, lets get this in. Thanks 🌃

@ankith26 ankith26 merged commit 72239a2 into pygame-community:main Oct 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs window pygame.Window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants