Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stubcheck error on windows, mark typealiases as such in typing #3147

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix stubcheck error on windows, mark typealiases as such in typing #3147

merged 1 commit into from
Oct 6, 2024

Conversation

zoldalma999
Copy link
Member

No description provided.

@zoldalma999 zoldalma999 requested a review from a team as a code owner October 6, 2024 09:48
ankith26
ankith26 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

bilhox
bilhox approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@damusss damusss added bugfix PR that fixes bug typing pygame.typing labels Oct 6, 2024
@ankith26 ankith26 added this to the 2.5.2 milestone Oct 6, 2024
damusss
damusss approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, LGTM 👍

@ankith26 ankith26 merged commit 16a8fd0 into pygame-community:main Oct 6, 2024
27 checks passed
@zoldalma999 zoldalma999 deleted the misc-fixes branch October 6, 2024 10:41
@aatle
Copy link
Contributor

aatle commented Oct 6, 2024

Note: (despite the 3 approving reviews and the passed checks,) the TypeAlias additions are actually problematic because it is unavailable for python <3.10.
See #3149 for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@bilhox bilhox bilhox approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug typing pygame.typing
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@zoldalma999 @aatle @ankith26 @bilhox @damusss