Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: controller is not multiphase init + workaround for wasm 313t #3137

Merged
merged 1 commit into from
Oct 4, 2024
Merged

wasm: controller is not multiphase init + workaround for wasm 313t #3137

merged 1 commit into from
Oct 4, 2024

Conversation

pmp-p
Copy link
Member

@pmp-p pmp-p commented Oct 2, 2024

also only controller.c is needed, the cython based controller_old is redundant here. Still fence possible use of cython code for future cpython versions.

@pmp-p pmp-p requested a review from a team as a code owner October 2, 2024 22:12
MyreMylar
MyreMylar approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM 👍

ankith26
ankith26 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🥳

@pmp-p pmp-p merged commit 2adb4b2 into pygame-community:main Oct 4, 2024
25 checks passed
@ankith26 ankith26 added this to the 2.5.2 milestone Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pmp-p @MyreMylar @ankith26