Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set error when too many numbers of argument in pygame.Color.from_colorspace #3125

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Set error when too many numbers of argument in pygame.Color.from_colorspace #3125

merged 3 commits into from
Sep 29, 2024

Conversation

bilhox
Copy link
Contributor

@bilhox bilhox commented Sep 28, 2024

Final step of @ankith26 's tasks in #2386 .
A year after ankith deprecated the use of this implementation, we can finally set an error for these.

Closes #2386

@bilhox bilhox requested a review from a team as a code owner September 28, 2024 09:26
@bilhox bilhox added color pygame.color bugfix PR that fixes bug labels Sep 28, 2024
damusss
damusss approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the deprecation guru, I can't not approve this. I guess no notice in the docs is needed because the docs never mentioned allowing more than the exact number of components.

ankith26
ankith26 reviewed Sep 28, 2024
View reviewed changes
test/color_test.py Outdated Show resolved Hide resolved
ankith26
ankith26 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🥳

@ankith26 ankith26 added this to the 2.5.2 milestone Sep 29, 2024
@ankith26 ankith26 merged commit fd47664 into pygame-community:main Sep 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug color pygame.color
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.

ability to call pygame.Color.from_colorspace methods with more than 4 args + python doctype wrong
3 participants
@bilhox @ankith26 @damusss