Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a compiler warning in debug mode #3124

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

ankith26
Copy link
Member

Currently I am facing a compiler warning because a 32-bit integer is being casted to a pointer type.

This PR has 0 impact for user facing releases, but this is needed for debug builds compiling without warnings.

@ankith26 ankith26 requested a review from a team as a code owner September 28, 2024 07:01
@damusss damusss added the Code quality/robustness Code quality and resilience to changes label Sep 28, 2024
@damusss damusss added this to the 2.5.2 milestone Sep 28, 2024
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, nice fix :)

Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoldalma999 zoldalma999 merged commit c00b777 into main Sep 29, 2024
25 checks passed
@damusss damusss deleted the ankith26-fix-comp-warning branch September 29, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants