Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added example on how Window behaves with WINDOWCLOSE and QUIT events #3115

Merged
merged 3 commits into from
Sep 27, 2024
Merged

added example on how Window behaves with WINDOWCLOSE and QUIT events #3115

merged 3 commits into from
Sep 27, 2024

Conversation

MrValdez
Copy link
Contributor

I've noticed that the new Window API have different behavior with events. I've updated the documentation to reflect this.

@MrValdez MrValdez requested a review from a team as a code owner September 23, 2024 08:30
ankith26
ankith26 reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🎉

Just a minor nitpick, can you format the lines to fit the 80/88 character limit?

@ankith26
Copy link
Member

While building the html docs (with py -m buildconfig docs) I am getting the following warnings:

/[my_path]/pygame-ce/docs/reST/ref/window.rst:49: ERROR: Unexpected indentation.
/[my_path]/pygame-ce/docs/reST/ref/window.rst:65: ERROR: Unexpected indentation.

The .. code-block:: python part must not be indented relative to the text, and the python code should be intended only once. Also I believe there should be one empty line before according to the rst spec.

@yunline yunline added docs window pygame.Window labels Sep 25, 2024
ankith26
ankith26 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing! 🎉

zoldalma999
zoldalma999 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for contributing!

@zoldalma999 zoldalma999 merged commit f554e77 into pygame-community:main Sep 27, 2024
1 check passed
@zoldalma999 zoldalma999 added this to the 2.5.2 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@zoldalma999 zoldalma999 zoldalma999 approved these changes

Assignees
No one assigned
Labels
docs window pygame.Window
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@MrValdez @ankith26 @zoldalma999 @yunline