Remove RGBATuple #3102
Merged
Remove RGBATuple #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My contention is that we don't need a type alias for this, we should show what functions actually return instead of adding an additional level of indirection. It is the documentation's job to say how the returned values should be interpreted, not the type system's.
ankith26
reviewed
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My contention is that we don't need a type alias for this, we should show what functions actually return instead of adding an additional level of indirection. It is the documentation's job to say how the returned values should be interpreted, not the type system's.
Previously discussed here: https://github.com/pygame-community/pygame-ce/pull/3076/files/cdf6e919b7aa397122e394c7b38d12c7bb48d002#r1726390905
I don't think we've reached consensus on this yet, but this PR needs to be resolved before 2.5.2 unless RGBATuple will "never" be able to be removed. Normally I'd err on the side of the status quo, but for this issue we can always add it back, but once it is in a full release it will be hard to remove.