Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pygame.typing.PathLike internal/private #3086

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Make pygame.typing.PathLike internal/private #3086

merged 3 commits into from
Aug 31, 2024

Conversation

aatle
Copy link
Contributor

@aatle aatle commented Aug 30, 2024

Closes #3085

Renames all occurrences from PathLike to _PathLike, and removes it from docs and __all__ list.

@aatle aatle requested a review from a team as a code owner August 30, 2024 01:05
damusss
damusss requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't particularly important, the rest looks good!

docs/reST/ref/typing.rst Outdated Show resolved Hide resolved
MyreMylar
MyreMylar approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable I agree that the the os.PathLike vs pygame.typing.PathLike is likely to be confusing.

@bilhox bilhox added the type hints Type hint checking related tasks label Aug 30, 2024
ankith26
ankith26 approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.2 milestone Aug 31, 2024
damusss
damusss approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@damusss damusss merged commit b0d45d1 into pygame-community:main Aug 31, 2024
26 checks passed
@aatle aatle deleted the change-pathlike branch August 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@ankith26 ankith26 ankith26 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
type hints Type hint checking related tasks
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.

Proposal: Remove pygame.typing.PathLike type from the API
5 participants
@aatle @MyreMylar @ankith26 @damusss @bilhox