Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix average_color docs and stubs to match implementation #3076

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix average_color docs and stubs to match implementation #3076

merged 2 commits into from
Aug 26, 2024

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 added docs type hints Type hint checking related tasks transform pygame.transform labels Aug 22, 2024
@Starbuck5 Starbuck5 requested a review from a team as a code owner August 22, 2024 05:56
@Starbuck5 Starbuck5 marked this pull request as draft August 22, 2024 07:21
@Starbuck5 Starbuck5 marked this pull request as ready for review August 24, 2024 04:55
ankith26
ankith26 approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

I agree with RGBATuple removal ideas being pushed to future issues/PRs

@ankith26 ankith26 added this to the 2.5.2 milestone Aug 24, 2024
damusss
damusss approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix :)

@damusss damusss merged commit c507028 into pygame-community:main Aug 26, 2024
26 checks passed
@Starbuck5 Starbuck5 deleted the transform_average_color_return_type branch September 16, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
docs transform pygame.transform type hints Type hint checking related tasks
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @ankith26 @damusss