-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opengl issue in Window
init
#3059
Fix opengl issue in Window
init
#3059
Conversation
On linux + wayland + swaywm, it does work! I'm not entirely sure I installed the branch correctly, but I see a red screen instead of black and I get import pygame
win = pygame.Window()
surf = win.get_surface() # get the window surface
print(f"{win.opengl=}")
while True:
for event in pygame.event.get():
if event.type == pygame.QUIT:
pygame.quit()
raise SystemExit
# draw something on the surface
surf.fill("red")
win.flip() # update the surface to the window |
As mentioned on #3056 I've tested this fix on my intel MacBook Pro and the PR fixes the issue (and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR 🥳
Fixes #3056
I can't actually test this on Windows because it's impossible to get framebuffer acceleration on Windows in SDL2: