Use SDL_TTF_VERSION_ATLEAST
#3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
approved these changes
Jul 16, 2024
| @@ -989,8 +983,7 @@ font_set_direction(PyObject *self, PyObject *arg, PyObject *kwarg) | |||
| writing this) This bug flips the top-to-bottom and bottom-to-top rendering. | |||
| So, this is a compat patch for that behavior | |||
| */ | |||
| #if SDL_VERSIONNUM(SDL_TTF_MAJOR_VERSION, SDL_TTF_MINOR_VERSION, \ | |||
| SDL_TTF_PATCHLEVEL) < SDL_VERSIONNUM(2, 22, 0) | |||
| #if !SDL_TTF_VERSION_ATLEAST(2, 22, 0) | |||
There was a problem hiding this comment.
Now that you made this PR, it got me thinking of whether this should be a compiled-version check or a linked-version check.
It isn't a big deal as probably over 99% of our users have matching compiled and linked versions, but it could be something to look into if you'd like.
There was a problem hiding this comment.
I think for the purposes of compat with the original code, it should be kept as-is in this pull. If we want to change that extreme edge-case behavior, that should be a separate pull IMO (maybe one that addresses it in a bunch of places that I'm sure have a similar problem)
There was a problem hiding this comment.
I don't think it would dynamically link if it was lower.
oddbookworm
approved these changes
Jul 17, 2024
Starbuck5
added
the
Code quality/robustness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2464 our SDL_ttf minimum version is 2.0.15, so we can use
SDL_TTF_VERSION_ATLEAST