Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version-getters SDL2/SDL3 #2975

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Version-getters SDL2/SDL3 #2975

merged 1 commit into from
Aug 18, 2024

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jul 7, 2024 •
edited
Loading

Continuing my SDL3 patch series.

This takes a look at all "version getters" from SDL and satellite libraries in one go, since they've all consistently updated.

@Starbuck5 Starbuck5 added the sdl3 label Jul 7, 2024
@Starbuck5 Starbuck5 requested a review from a team as a code owner July 7, 2024 08:16
@Starbuck5 Starbuck5 marked this pull request as draft July 7, 2024 08:16
@Starbuck5 Starbuck5 marked this pull request as ready for review July 7, 2024 08:36
@ankith26 ankith26 added this to the 2.5.1 milestone Jul 7, 2024
@Starbuck5 Starbuck5 removed this from the 2.5.1 milestone Aug 7, 2024
ankith26
ankith26 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🥳

@ankith26 ankith26 added this to the 2.5.2 milestone Aug 15, 2024
MyreMylar
MyreMylar approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all looks good to me and the relevant tests and functions for version checking all still work. 👍

@MyreMylar MyreMylar merged commit aff0705 into pygame-community:main Aug 18, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
sdl3
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @MyreMylar @ankith26