-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning about 7.1 stereo on set_source_location #2881
Add warning about 7.1 stereo on set_source_location #2881
Conversation
What about testing the available hardware/audio device channels as an advised safety wrapper? e.g.
Or we could handle this ourselves in the code for |
That isn't a bad idea. I went with my current recommendation because it will (theoretically) keep the source position working. If someone has some crazy fancy setup that supports 7.1 audio, and SDL emulates stereo on top of it, and the source location is set, they should still be able to hear the sound coming from an angle. I'm hesitant to ignore an exception (or never even try) based on Mix_QuerySpec, since SDL will eventually fix this and then we'll need to remove that code. Also it gives no feedback to the user on why the function isn't working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK LGTM 👍
Hopefully it gets fixed SDL side at some point and we can un-caveat this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM of course 👍
d5e0f5e
to
7a8997b
Compare
For #2751