Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Circle.collidelist/collidelistall() #2880

Merged
merged 10 commits into from
Sep 29, 2024

Conversation

damusss
Copy link
Member

@damusss damusss commented May 27, 2024

@damusss damusss requested a review from a team as a code owner May 27, 2024 20:06
@itzpr3d4t0r itzpr3d4t0r added New API This pull request may need extra debate as it adds a new class or function to pygame geometry pygame.geometry labels May 28, 2024
docs/reST/ref/geometry.rst Outdated Show resolved Hide resolved
src_c/circle.c Outdated Show resolved Hide resolved
src_c/circle.c Outdated Show resolved Hide resolved
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff aside (and I might be a bit biased here ofc) but this LGTM. Having efficient multi-collision functions is crucial in many programs but this time it's even better since we accept any kind of shape, instead of just Circles (like Rect.collidelist does).

src_c/circle.c Outdated Show resolved Hide resolved
test/geometry_test.py Outdated Show resolved Hide resolved
test/geometry_test.py Outdated Show resolved Hide resolved
test/geometry_test.py Outdated Show resolved Hide resolved
@damusss
Copy link
Member Author

damusss commented Jun 2, 2024

Thanks, I modified as needed

Copy link
Contributor

@Emc2356 Emc2356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something small but still important if someone passes a large amount of objetcs

src_c/circle.c Show resolved Hide resolved
@itzpr3d4t0r itzpr3d4t0r added this to the 2.5.2 milestone Aug 18, 2024
@itzpr3d4t0r itzpr3d4t0r mentioned this pull request Aug 20, 2024
89 tasks
@damusss
Copy link
Member Author

damusss commented Sep 15, 2024

When this gets enough approvals, either I have to merge it, or the person who does should squash & merge and add this in the commit message:

Co-authored-by: Emc2356 <[email protected]>
Co-authored-by: NovialRiptide <[email protected]>
Co-authored-by: ScriptLineStudios <[email protected]>
Co-authored-by: Avaxar <[email protected]>
Co-authored-by: maqa41 <[email protected]>
Co-authored-by: itzpr3d4t0r <[email protected]>

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 merged commit a4eec3a into pygame-community:main Sep 29, 2024
25 checks passed
@damusss damusss deleted the geometry-circle-collidelist branch September 29, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geometry pygame.geometry New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants