Deprecate setup.py sdist, suggest and use replacement pypa/build based command
#2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-meson-sdist
branch
from
a8a6b0a to
3f80166
Compare
Starbuck5
reviewed
May 30, 2024
If that's merged, how does it need taking care of? I don't understand. I ran this locally and saw the generated docs weren't in the sdist. |
Yes, that's intended. And the purpose of #2853 is to ensure that the setup docs command runs atleast once as part of the build process itself (and therefore, runs when the sdist is installed on the user side) so in the end, the user still has the generated docs as before. |
Starbuck5
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use pypa/build to make an sdist file, now that we have the meson buildconfig.
I added a
.gitattributesfile, to skip a few files and ensure that the generated sdist is identical* to the one generated bysetup.py sdist* There is one point of difference, the
docs/generatedfolder is included in the sdist generated bysetup.py sdist, but not the pypa/build sdist. This is one of the things that will be taken care due to #2853 being merged.PS: this PR also fixes a little bug in #2853 (so this is a sort of a successor PR to that)