Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate images in tutorials #2871

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

MyreMylar
Copy link
Member

Seems like we had multiple copies of some images in the docs source files.

@Gabryel-lima
Copy link

Seems like we had multiple copies of some images in the docs source files.

Is it just a case of transporting the assets dir, isolating it, passing the new readme paths and committing back? How did I see what you suggested? Because your observation was very good, I hadn't even noticed it when I was translating. Can I change? I'm sorry for the amount of questions, I'm just learning. I had never contributed to open source before.

Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Saves about 0.9 mb as well (my generated folder went from 22.1 mb on current main to 21.2 mb on this branch) which is nice

Copy link

@Gabryel-lima Gabryel-lima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, great! I'm even going to adjust my translation branch. I will even adjust my translation branch, if it is approved here. I strongly believe so

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.0 milestone May 25, 2024
@ankith26 ankith26 merged commit 5ce5eca into main May 25, 2024
3 checks passed
@ankith26 ankith26 deleted the fix_red_or_black_assets branch May 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants