Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint undefined usage error in sysfont #2858

Merged
merged 1 commit into from
May 18, 2024

Conversation

ankith26
Copy link
Member

Fixes the recent pylint fails, by moving around the conditional imports to the functions where they are actually invoked.

@ankith26 ankith26 requested a review from a team as a code owner May 16, 2024 13:57
Copy link
Member

@novialriptide novialriptide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Starbuck5
Copy link
Member

This PR makes me grumpy, I’m tired of package updates breaking our CI over and over.

So I’d hope something like this can be used- #2699

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m on my phone right now so I can’t really verify, but I trust that Ankith made this patch properly.

@Starbuck5 Starbuck5 merged commit 0449dca into main May 18, 2024
38 checks passed
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone May 18, 2024
@Starbuck5 Starbuck5 deleted the ankith26-fix-pylint-error branch May 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants