Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit check and error for system cursor #2843

Merged
merged 1 commit into from
May 8, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented May 7, 2024

PR to fix #2842

I am not sure how this issue is coming up only now, I went through the SDL code for it and there is no clear error raising path for this case.

@ankith26 ankith26 requested a review from a team as a code owner May 7, 2024 11:15
@yunline yunline added cursors pygame.cursors bugfix PR that fixes bug labels May 8, 2024
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change.

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe an issue on the SDL side is also a good idea?

@oddbookworm oddbookworm merged commit b7e1aa3 into main May 8, 2024
39 checks passed
@ankith26 ankith26 deleted the ankith26-fix-cursor-error branch May 8, 2024 17:44
@ankith26 ankith26 added this to the 2.5.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR that fixes bug cursors pygame.cursors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New test fail in set_system_cursor when integer value passed is out of range
5 participants