relax convert conditions #2839
Merged
relax convert conditions #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpfeiffer
force-pushed
the
permissive-converting
branch
from
dc816e8 to
b0a3432
Compare
ankith26
requested changes
May 6, 2024
|
@ankith26 I'll just change some convert tests to not create a window, is that OK? |
|
Yes, that would be cool |
|
Converted to a draft since it has some feedback left to resolve. Looks like a nice improvement! |
ankith26
approved these changes
May 21, 2024
|
Can anybody please tell me why the CI is failing, I don't see any failing tests and just red marks |
Error code 3221225477 is a segfault, but I don’t know what segfaulted from the log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason convert() has to wait for the display to be initialised. If a parameter with the target surface is provided, we can always convert.