Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SDL to 2.30.3 #2837

Merged
merged 2 commits into from
May 6, 2024
Merged

Updated SDL to 2.30.3 #2837

merged 2 commits into from
May 6, 2024

Conversation

oddbookworm
Copy link
Member

No description provided.

@oddbookworm oddbookworm requested a review from a team as a code owner May 4, 2024 13:28
@oddbookworm
Copy link
Member Author

Closing and reopening due to possible spurious failure

@oddbookworm oddbookworm closed this May 4, 2024
@oddbookworm oddbookworm reopened this May 4, 2024
@Starbuck5
Copy link
Member

Closing and reopening due to possible spurious failure.

You can re run these things by pressing a button!

@damusss
Copy link
Member

damusss commented May 4, 2024

You can re run these things by pressing a button!
@Starbuck5 What permission level has this button? (just to make sure I am not blind)

@Starbuck5
Copy link
Member

@Damus666 You're not a member of the pygame-community org on GitHub, you don't have permissions for this.

@damusss
Copy link
Member

damusss commented May 4, 2024

@Damus666 You're not a member of the pygame-community org on GitHub, you don't have permissions for this.

Okay thanks, I was just making sure of it :)

Starbuck5
Starbuck5 approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a local test for good measure, it passed.

ankith26
ankith26 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.0 milestone May 6, 2024
@ankith26 ankith26 merged commit aa1363e into main May 6, 2024
68 of 71 checks passed
@ankith26 ankith26 deleted the SDL-2.30.3 branch May 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
dependencies SDL
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oddbookworm @Starbuck5 @damusss @ankith26