Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup codebase, docs and examples with American spelling #2827

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

damusss
Copy link
Member

@damusss damusss commented Apr 26, 2024

I used Visual Studio Code search tool to find all the occasions for non American spelling, looked quickly at each one and chose to replace them or not.
I ignored file names, files, links and the C/PY color dict files (where both spellings are intended)
The reason is:

  • the codebase should use one convention and stick to it
  • the American spelling is preferred to match the actual pygame classes and methods such as Color and grayscale()

For now I considered the following non American spelling (you can request more):

  • grey -> gray
  • colour -> color

If all checks pass it means I didn't break any variable name.

@damusss damusss requested a review from a team as a code owner April 26, 2024 16:47
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddbookworm oddbookworm merged commit e404dbc into pygame-community:main Apr 27, 2024
39 checks passed
@oddbookworm oddbookworm added this to the 2.5.0 milestone Apr 27, 2024
@damusss damusss deleted the american-spelling-cleanup branch April 27, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants