Use macros for (Bytes|Bits)PerPixel compat in SDL3 #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
added
Code quality/robustness
Starbuck5
removed
the
Code quality/robustness
This doesn't fix every read/write of these struct members, but it gets 99% of them. And this is hard to test (SDL3-wise) without everything else compiling on SDL3, which it doesn't without a lot more patches.
Starbuck5
force-pushed
the
prep-BitsBytesPerPixel-changes-sdl3
branch
from
9eb7813 to
4230f16
Compare
Starbuck5
commented
Apr 14, 2024
There was a problem hiding this comment.
Had to use a different strategy here because this file doesn't include _pygame.h, and I didn't want to try to edit it so it did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix every read/write of these struct members, but it gets 99% of them. And this is hard to test (SDL3wise) without everything else compiling on SDL3, which it doesn't without a lot more patches.
For SDL2, this doesn't change how it compiles at all.