Unify freetype init codepaths #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The freetype.Font init code has a windows codepath and an "everything else" codepath. I think that the windows codepath would work everywhere, so let's try using it everywhere.
Starbuck5
added
Code quality/robustness
ankith26
approved these changes
Apr 25, 2024
oddbookworm
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The freetype.Font init code has a windows codepath and an "everything else" codepath. I think that the windows codepath would work everywhere, so let's try using it everywhere.
Why am I mucking around with this? Because SDL3 changes rwops stuff and freetype looks like it might be the most complex use of rwops we have. If we can make it simpler that will help the transition. This is similar to #2717 in that regard.