Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP572 Use Python's assignment expression #2782

Merged
merged 2 commits into from
Apr 9, 2024
Merged

PEP572 Use Python's assignment expression #2782

merged 2 commits into from
Apr 9, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 29, 2024 •
edited
Loading

@cclauss cclauss requested a review from a team as a code owner March 29, 2024 21:18
oddbookworm
oddbookworm requested changes Mar 30, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change I'd like to see, but overall looks good!

(I know the timestamp says 19 hours ago, didn't realize I hadn't published my review 😓)

test/mixer_test.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor Author

cclauss commented Mar 31, 2024

Failing test is fixed in

ankith26
ankith26 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@cclauss cclauss requested a review from oddbookworm April 2, 2024 13:38
@ankith26 ankith26 added this to the 2.5.0 milestone Apr 4, 2024
@oddbookworm @cclauss
Revert walrus for readability
b72fee7 
Co-authored-by: Christian Clauss <[email protected]>
oddbookworm
oddbookworm approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is running again, as long as it passes I'm good to merge this in

@oddbookworm oddbookworm merged commit bf66594 into pygame-community:main Apr 9, 2024
30 checks passed
@cclauss cclauss deleted the auto-walrus branch April 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddbookworm oddbookworm oddbookworm approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @ankith26 @oddbookworm