Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apt upgrade in CI #2778

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Remove apt upgrade in CI #2778

merged 1 commit into from
Apr 1, 2024

Conversation

ankith26
Copy link
Member

I can't seem to remember why the update/upgrade was added in CI in the first place. Anyways, I'm now trying to remove it because every once in a while this step likes to break, and I don't think there's a benefit of having this extra step

@ankith26 ankith26 requested a review from a team as a code owner March 28, 2024 14:18
@Starbuck5
Copy link
Member

Maybe keep the update but remove the upgrade? https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/customizing-github-hosted-runners#installing-software-on-ubuntu-runners

@ankith26 ankith26 force-pushed the ankith26-ubuntu-ci-fix branch from edfa29b to c49c5e8 Compare March 29, 2024 08:19
@ankith26
Copy link
Member Author

In my latest commit upgrade has been removed but update has been kept as it was

@ankith26 ankith26 changed the title Remove apt update/upgrade in CI Remove apt upgrade in CI Mar 29, 2024
@ankith26 ankith26 added the CI Issue with the Continuous Integration (CI), the actions/bots that test things label Mar 29, 2024
@Starbuck5 Starbuck5 merged commit 5cda34f into main Apr 1, 2024
3 checks passed
@Starbuck5 Starbuck5 deleted the ankith26-ubuntu-ci-fix branch April 1, 2024 07:12
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants