transform.scale: softstretch SDL2/SDL3 compat #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
force-pushed
the
transform-sdl3
branch
from
4bd15c5 to
cd52bcb
Compare
MyreMylar
approved these changes
Feb 4, 2024
|
I didn't recall ever testing out SDL2's SDL_SoftStretchLinear, so I gave it a quick test to respond to your comment. I did a small scale test, just looked at one image and did a 1.5x upscale. Visually it looked similar. Performance-wise, SDL_SoftStretchLinear took 1.28 - 1.31 seconds to do 1000 scales. Our smoothscale does 1000 scales in 0.83 - 0.86 seconds using SSE2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SDL3, SDL_SoftStretch takes a ScaleMode parameter. For this case, it should be "nearest neighbor" because this is our basic scaling function.
With this change, the transform module compiles with SDL3.