-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements dev file #2699
Closed
Closed
Requirements dev file #2699
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
84541ff
Rebased with main
oddbookworm e938e0c
fixed an oopsie in requirements.txt name
oddbookworm 9fe8be2
fixed weird issue with beginning of requirements file
oddbookworm 7b07007
fix typo in pylint
oddbookworm f7d3ecc
removed opencv and pinned lower numpy version for pypy
oddbookworm 00403b2
Update requirements-dev.txt
MyreMylar b7e9424
updated dep versions
oddbookworm 2c11bfa
Added meson
oddbookworm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
name: macOS | ||
|
||
# Run CI only when a release is created, on changes to main branch, or any PR | ||
# to main. Do not run CI on any other branch. Also, skip any non-source changes | ||
# Run CI only when a release is created, on changes to main branch, or any PR | ||
# to main. Do not run CI on any other branch. Also, skip any non-source changes | ||
# from running on CI | ||
on: | ||
push: | ||
|
@@ -27,7 +27,7 @@ on: | |
- '.github/workflows/*.yml' | ||
# re-include current file to not be excluded | ||
- '!.github/workflows/build-macos.yml' | ||
|
||
# the github release drafter can call this workflow | ||
workflow_call: | ||
|
||
|
@@ -54,7 +54,7 @@ jobs: | |
uses: actions/[email protected] | ||
with: | ||
path: ${{ github.workspace }}/pygame_mac_deps_${{ matrix.macarch }} | ||
# The hash of all files in buildconfig manylinux-build and macdependencies is | ||
# The hash of all files in buildconfig manylinux-build and macdependencies is | ||
# the key to the cache. If anything changes here, the deps are built again | ||
key: macdep-${{ hashFiles('buildconfig/manylinux-build/**') }}-${{ hashFiles('buildconfig/macdependencies/*.sh') }}-${{ matrix.macarch }}-${{ matrix.os }} | ||
lookup-only: true | ||
|
@@ -86,36 +86,36 @@ jobs: | |
# builds on macOS. This needs to be manually kept updated so that each | ||
# of these builds take roughly the same time | ||
include: | ||
- { | ||
- { | ||
name: "x86_64 (CPython 3.9 - 3.12)", | ||
macarch: x86_64, | ||
os: macos-13, | ||
pyversions: "cp3{9,10,11,12}-*", | ||
} | ||
|
||
- { | ||
- { | ||
name: "x86_64 (Python 3.8)", | ||
macarch: x86_64, | ||
os: macos-13, | ||
# CPython/PyPy 3.8 | ||
pyversions: "?p38-*", | ||
} | ||
|
||
- { | ||
- { | ||
name: "x86_64 (PyPy 3.9 and 3.10)", | ||
macarch: x86_64, | ||
os: macos-13, | ||
pyversions: "pp39-* pp310-*", | ||
} | ||
|
||
- { | ||
- { | ||
name: "arm64 (CPython 3.8 - 3.10)", | ||
macarch: arm64, | ||
os: macos-14, | ||
pyversions: "cp3{8,9,10}-*", | ||
} | ||
|
||
- { | ||
- { | ||
name: "arm64 (CPython 3.11 - 3.12)", | ||
macarch: arm64, | ||
os: macos-14, | ||
|
@@ -152,7 +152,7 @@ jobs: | |
bash ./install_mac_deps.sh | ||
|
||
CIBW_BEFORE_BUILD: | | ||
pip install numpy Sphinx"<7.2.0" | ||
pip install -r requirements-dev.txt | ||
python setup.py docs | ||
cp -r ${{ github.workspace }}/pygame_mac_deps_${{ matrix.macarch }} ${{ github.workspace }}/pygame_mac_deps | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ jobs: | |
- uses: actions/[email protected] | ||
|
||
- name: Install deps | ||
run: python3 -m pip install pylint sphinx"<7.2.0" | ||
run: python3 -m pip install -r requirements-dev.txt | ||
|
||
- name: Check code linting | ||
run: pylint src_py docs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
numpy | ||
pylint<=3.1.0 | ||
meson | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meson is already covered due to specifying
meson-python
in[build-system] requires
ofpyproject.toml
, so like the rest it need not be re-specified here.However, you could specify
mypy
here instead, it's used by the stubcheck program we have