Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL 2.29.3 pre-release #2690

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Jan 22, 2024

Moved #2684 to an upstream branch

@Matiiss Matiiss requested a review from a team as a code owner January 22, 2024 21:46
@Matiiss Matiiss marked this pull request as draft January 22, 2024 21:47
@oddbookworm
Copy link
Member

Note that there is a small fix in surface.c that fixes a couple broken behaviors from libsdl-org/SDL@04e98d2

@Starbuck5
Copy link
Member

Note that there is a small fix in surface.c that fixes a couple broken behaviors from libsdl-org/SDL@04e98d2

Is this a broken behavior we should complain or is this just a change in behavior? Seems like the latter.

@Starbuck5 Starbuck5 changed the title SDL 2.29.2 pre-release SDL 2.29.3 pre-release Jan 28, 2024
@oddbookworm
Copy link
Member

Is this a broken behavior we should complain or is this just a change in behavior? Seems like the latter.

Yeah, it seems like it was an intentional change to emit an SDL error message when something went wrong

…into oddbookwormfix-error-reporting-sdl-2.29.2+
@Starbuck5 Starbuck5 merged commit 61a1706 into main Feb 4, 2024
30 checks passed
@ankith26 ankith26 deleted the oddbookwormfix-error-reporting-sdl-2.29.2+ branch March 6, 2024 05:26
@ankith26 ankith26 added this to the 2.5.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants